From da90bfee499eab087a5d5fb582f16b4d0a05449f Mon Sep 17 00:00:00 2001
From: Konrad Neitzel <konrad@kneitzel.de>
Date: Mon, 6 May 2024 12:50:24 +0200
Subject: [PATCH] Updated dependencies, activates PMD Plugin again: new version
 supports Java 21.

---
 pom.xml                                       | 20 ++++++++++--------
 src/main/java/de/kneitzel/MainWindow.java     | 21 +++++++++++--------
 .../resources/de/kneitzel/MainWindow.fxml     |  2 +-
 3 files changed, 24 insertions(+), 19 deletions(-)

diff --git a/pom.xml b/pom.xml
index ff50573..1f6f0bd 100644
--- a/pom.xml
+++ b/pom.xml
@@ -23,7 +23,7 @@
         <jar.filename>${project.artifactId}-${project.version}</jar.filename>
 
         <!-- Dependency versions -->
-        <javafx.version>19.0.2.1</javafx.version>
+        <javafx.version>21.0.3</javafx.version>
         <jetbrains.annotations.version>24.1.0</jetbrains.annotations.version>
         <junit.version>5.10.2</junit.version>
         <lombok.version>1.18.32</lombok.version>
@@ -33,20 +33,20 @@
 		<maven.clean.plugin>3.3.2</maven.clean.plugin>
         <maven.compiler.plugin>3.13.0</maven.compiler.plugin>
         <maven.dependency.plugin>3.6.1</maven.dependency.plugin>
-		<maven.deploy.plugin>3.1.1</maven.deploy.plugin>
+		<maven.deploy.plugin>3.1.2</maven.deploy.plugin>
 		<maven.enforcer.plugin>3.4.1</maven.enforcer.plugin>
-		<maven.install.plugin>3.1.1</maven.install.plugin>
-		<maven.jar.plugin>3.3.0</maven.jar.plugin>
+		<maven.install.plugin>3.1.2</maven.install.plugin>
+		<maven.jar.plugin>3.4.1</maven.jar.plugin>
 		<maven.resources.plugin>3.3.1</maven.resources.plugin>
 		<maven.site.plugin>4.0.0-M13</maven.site.plugin>
         <maven.surfire.plugin>3.2.5</maven.surfire.plugin>
         <moditect.maven.plugin>1.0.0.RC2</moditect.maven.plugin>
         <jpackage.maven.plugin>0.1.5</jpackage.maven.plugin>
-        <maven.pmd.version>3.21.2</maven.pmd.version>
+        <maven.pmd.version>3.22.0</maven.pmd.version>
         <codehaus.version.plugin>2.16.2</codehaus.version.plugin>
         <javafx.maven.plugin>0.0.8</javafx.maven.plugin>
-        <spotbugs.maven.plugin>4.8.3.1</spotbugs.maven.plugin>
-        <spotbugs.version>4.8.3</spotbugs.version>
+        <spotbugs.maven.plugin>4.8.5.0</spotbugs.maven.plugin>
+        <spotbugs.version>4.8.5</spotbugs.version>
 
         <!-- other properties -->
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
@@ -236,7 +236,6 @@
                 </executions>
             </plugin>
 
-            <!--
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-pmd-plugin</artifactId>
@@ -254,12 +253,15 @@
                     <execution>
                         <phase>prepare-package</phase>
                         <goals>
+                            <!-- pmd target does not stop build when violations are found -->
                             <goal>pmd</goal>
+
+                            <!-- check stops the build when violations are found -->
+                            <!-- <goal>check</goal> -->
                         </goals>
                     </execution>
                 </executions>
             </plugin>
-            -->
 
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
diff --git a/src/main/java/de/kneitzel/MainWindow.java b/src/main/java/de/kneitzel/MainWindow.java
index 4398a1b..fd731f4 100644
--- a/src/main/java/de/kneitzel/MainWindow.java
+++ b/src/main/java/de/kneitzel/MainWindow.java
@@ -3,7 +3,6 @@ package de.kneitzel;
 import javafx.event.ActionEvent;
 import javafx.fxml.FXML;
 import javafx.fxml.Initializable;
-import javafx.scene.control.Button;
 import javafx.scene.control.TextField;
 
 import java.net.URL;
@@ -11,20 +10,24 @@ import java.util.ResourceBundle;
 
 public class MainWindow implements Initializable {
 
+
+    private int counter = 0;
+
     @FXML
     private TextField textField;
-    public Button button;
+
     @Override
-    public void initialize(URL url, ResourceBundle resourceBundle) {
-        if (button == null) {
-            textField.setText("Button is null");
-        } else {
-            textField.setText("Button is not null");
-        }
+    public void initialize(URL location, ResourceBundle resources) {
+        displayCounter();
+    }
+
+    private void displayCounter() {
+        textField.setText("Click counter: " + counter);
     }
 
     @FXML
     private void onButtonClick(ActionEvent actionEvent) {
-
+        counter++;
+        displayCounter();
     }
 }
diff --git a/src/main/resources/de/kneitzel/MainWindow.fxml b/src/main/resources/de/kneitzel/MainWindow.fxml
index 07c63e6..3b6f267 100644
--- a/src/main/resources/de/kneitzel/MainWindow.fxml
+++ b/src/main/resources/de/kneitzel/MainWindow.fxml
@@ -5,7 +5,7 @@
 
 <AnchorPane prefHeight="127.0" prefWidth="209.0" xmlns="http://javafx.com/javafx/17.0.2-ea" xmlns:fx="http://javafx.com/fxml/1" fx:controller="de.kneitzel.MainWindow">
    <children>
-      <Button fx:id="button" layoutX="44.0" layoutY="70.0" mnemonicParsing="false" onAction="#onButtonClick" text="Button" />
+      <Button fx:id="button" layoutX="44.0" layoutY="70.0" mnemonicParsing="false" onAction="#onButtonClick" text="Click Me" />
       <TextField fx:id="textField" layoutX="14.0" layoutY="24.0" />
    </children>
 </AnchorPane>